monkee.ch/snac2
1
0
Fork 0
mirror of https://codeberg.org/grunfink/snac2.git synced 2024-11-25 22:45:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

Quick fix to "Script self-injection in edit box".

Browse source 
In the 'Edit...' box, the sourceContent (which was written by a user)
has its < replaced with &lt; . This issue does not propagate to the
public timeline nor to the recipients of the post.

Reference: https://codeberg.org/grunfink/snac2/issues/53
This commit is contained in:
default 2023-06-16 09:25:32 +02:00
parent 57761020b7
commit 5be2239467
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
html.c
View file

@ -668,9 +668,11 @@ xs_str *html_entry_controls(snac *snac, xs_str *os, const xs_dict *msg, const ch
s = xs_str_cat(s, "</form>\n");
char *prev_src = xs_dict_get(msg, "sourceContent");
const char *prev_src1 = xs_dict_get(msg, "sourceContent");
if (!xs_is_null(prev_src1) && strcmp(actor, snac->actor) == 0) {
xs *prev_src = xs_replace(prev_src1, "<", "&lt;");
if (!xs_is_null(prev_src) && strcmp(actor, snac->actor) == 0) {
/* post can be edited */
xs *s1 = xs_fmt(
"<p><details><summary>%s</summary>\n"