upd: completely change handling of indexable

packages/backend/migration/1700228972000-update-indexable.js

@@ -0,0 +1,15 @@
+export class UpdateIndexable1700228972000 {
+    name = 'UpdateIndexable1700228972000'
+
+    async up(queryRunner) {
+        await queryRunner.query(`ALTER TABLE "user" RENAME COLUMN "isIndexable" TO "noindex"`);
+        await queryRunner.query(`ALTER TABLE "user" ALTER COLUMN "noindex" SET DEFAULT false`);
+        await queryRunner.query(`UPDATE "user" SET "noindex" = false WHERE "noindex" = true`);
+    }
+
+    async down(queryRunner) {
+        await queryRunner.query(`UPDATE "user" SET "noindex" = true WHERE "noindex" = false`);
+        await queryRunner.query(`ALTER TABLE "user" ALTER COLUMN "noindex" SET DEFAULT true`);
+        await queryRunner.query(`ALTER TABLE "user" RENAME COLUMN "noindex" TO "isIndexable"`);
+    }
+}

packages/backend/src/core/NoteCreateService.ts

@@ -223,7 +223,7 @@ export class NoteCreateService implements OnApplicationShutdown {
 		username: MiUser['username'];
 		host: MiUser['host'];
 		isBot: MiUser['isBot'];
-		isIndexable: MiUser['isIndexable'];
+		noindex: MiUser['noindex'];
 	}, data: Option, silent = false): Promise<MiNote> {
 		// チャンネル外にリプライしたら対象のスコープに合わせる
 		// (クライアントサイドでやっても良い処理だと思うけどとりあえずサーバーサイドで)
@@ -384,7 +384,7 @@ export class NoteCreateService implements OnApplicationShutdown {
 		username: MiUser['username'];
 		host: MiUser['host'];
 		isBot: MiUser['isBot'];
-		isIndexable: MiUser['isIndexable'];
+		noindex: MiUser['noindex'];
 	}, data: Option, silent = false): Promise<MiNote> {
 		// チャンネル外にリプライしたら対象のスコープに合わせる
 		// (クライアントサイドでやっても良い処理だと思うけどとりあえずサーバーサイドで)
@@ -642,7 +642,7 @@ export class NoteCreateService implements OnApplicationShutdown {
 		username: MiUser['username'];
 		host: MiUser['host'];
 		isBot: MiUser['isBot'];
-		isIndexable: MiUser['isIndexable'];
+		noindex: MiUser['noindex'];
 	}, data: Option, silent: boolean, tags: string[], mentionedUsers: MinimumUser[]) {
 		const meta = await this.metaService.fetch();
 
@@ -873,7 +873,7 @@ export class NoteCreateService implements OnApplicationShutdown {
 		}
 
 		// Register to search database
-		if (user.isIndexable) this.index(note);
+		if (!user.noindex) this.index(note);
 	}
 
 	@bindThis
@@ -882,7 +882,7 @@ export class NoteCreateService implements OnApplicationShutdown {
 		username: MiUser['username'];
 		host: MiUser['host'];
 		isBot: MiUser['isBot'];
-		isIndexable: MiUser['isIndexable'];
+		noindex: MiUser['noindex'];
 	}, data: Option, silent: boolean, tags: string[], mentionedUsers: MinimumUser[]) {
 		const meta = await this.metaService.fetch();
 
@@ -972,7 +972,7 @@ export class NoteCreateService implements OnApplicationShutdown {
 		}
 
 		// Register to search database
-		if (user.isIndexable) this.index(note);
+		if (!user.noindex) this.index(note);
 	}
 
 	@bindThis

packages/backend/src/core/NoteEditService.ts

@@ -224,7 +224,7 @@ export class NoteEditService implements OnApplicationShutdown {
 		username: MiUser['username'];
 		host: MiUser['host'];
 		isBot: MiUser['isBot'];
-		isIndexable: MiUser['isIndexable'];
+		noindex: MiUser['noindex'];
 	}, editid: MiNote['id'], data: Option, silent = false): Promise<MiNote> {
 		if (!editid) {
 			throw new Error('fail');
@@ -499,7 +499,7 @@ export class NoteEditService implements OnApplicationShutdown {
 		username: MiUser['username'];
 		host: MiUser['host'];
 		isBot: MiUser['isBot'];
-		isIndexable: MiUser['isIndexable'];
+		noindex: MiUser['noindex'];
 	}, data: Option, silent: boolean, tags: string[], mentionedUsers: MinimumUser[]) {
 		// Register host
 		if (this.userEntityService.isRemoteUser(user)) {
@@ -688,7 +688,7 @@ export class NoteEditService implements OnApplicationShutdown {
 		}
 
 		// Register to search database
-		if (user.isIndexable) this.index(note);
+		if (!user.noindex) this.index(note);
 	}
 
 	@bindThis

packages/backend/src/core/activitypub/ApRendererService.ts

@@ -525,7 +525,7 @@ export class ApRendererService {
 			discoverable: user.isExplorable,
 			publicKey: this.renderKey(user, keypair, '#main-key'),
 			isCat: user.isCat,
-			noindex: user.isIndexable,
+			noindex: user.noindex,
 			speakAsCat: user.speakAsCat,
 			attachment: attachment.length ? attachment : undefined,
 		};

packages/backend/src/core/activitypub/models/ApPersonService.ts

@@ -310,7 +310,7 @@ export class ApPersonService implements OnModuleInit {
 					backgroundId: null,
 					lastFetchedAt: new Date(),
 					name: truncate(person.name, nameLength),
-					isIndexable: (person as any).noindex ?? true,
+					noindex: (person as any).noindex ?? false,
 					isLocked: person.manuallyApprovesFollowers,
 					movedToUri: person.movedTo,
 					movedAt: person.movedTo ? new Date() : null,
@@ -477,7 +477,7 @@ export class ApPersonService implements OnModuleInit {
 			isBot: getApType(object) === 'Service' || getApType(object) === 'Application',
 			isCat: (person as any).isCat === true,
 			speakAsCat: (person as any).speakAsCat != null ? (person as any).speakAsCat === true : (person as any).isCat === true,
-			isIndexable: (person as any).noindex ?? true,
+			noindex: (person as any).noindex ?? false,
 			isLocked: person.manuallyApprovesFollowers,
 			movedToUri: person.movedTo ?? null,
 			alsoKnownAs: person.alsoKnownAs ?? null,

packages/backend/src/core/activitypub/type.ts

@@ -184,7 +184,7 @@ export interface IActor extends IObject {
 	};
 	'vcard:bday'?: string;
 	'vcard:Address'?: string;
-	isIndexable?: boolean;
+	noindex?: boolean;
 	listenbrainz?: string;
 	backgroundUrl?: string;
 }

packages/backend/src/core/entities/UserEntityService.ts

@@ -399,7 +399,7 @@ export class UserEntityService implements OnModuleInit {
 			}))) : [],
 			isBot: user.isBot,
 			isCat: user.isCat,
-			isIndexable: user.isIndexable,
+			noindex: user.noindex,
 			isSilenced: user.isSilenced || this.roleService.getUserPolicies(user.id).then(r => !r.canPublicNote),
 			speakAsCat: user.speakAsCat ?? false,
 			approved: user.approved,

packages/backend/src/models/User.ts

@@ -189,10 +189,10 @@ export class MiUser {
 	public isSilenced: boolean;
 
 	@Column('boolean', {
-		default: true,
+		default: false,
-		comment: 'Whether the User\'s notes get indexed.',
+		comment: 'Whether the User\'s notes dont get indexed.',
 	})
-	public isIndexable: boolean;
+	public noindex: boolean;
 
 	@Column('boolean', {
 		default: false,

packages/backend/src/models/json-schema/user.ts

@@ -79,7 +79,7 @@ export const packedUserLiteSchema = {
 			type: 'boolean',
 			nullable: false, optional: false,
 		},
-		isIndexable: {
+		noindex: {
 			type: 'boolean',
 			nullable: false, optional: false,
 		},

packages/backend/src/server/api/endpoints/i/update.ts

@@ -177,7 +177,7 @@ export const paramDef = {
 		autoAcceptFollowed: { type: 'boolean' },
 		noCrawle: { type: 'boolean' },
 		preventAiLearning: { type: 'boolean' },
-		isIndexable: { type: 'boolean' },
+		noindex: { type: 'boolean' },
 		isBot: { type: 'boolean' },
 		isCat: { type: 'boolean' },
 		speakAsCat: { type: 'boolean' },
@@ -279,7 +279,7 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-
 			if (typeof ps.isExplorable === 'boolean') updates.isExplorable = ps.isExplorable;
 			if (typeof ps.hideOnlineStatus === 'boolean') updates.hideOnlineStatus = ps.hideOnlineStatus;
 			if (typeof ps.publicReactions === 'boolean') profileUpdates.publicReactions = ps.publicReactions;
-			if (typeof ps.isIndexable === 'boolean') updates.isIndexable = ps.isIndexable;
+			if (typeof ps.noindex === 'boolean') updates.noindex = ps.noindex;
 			if (typeof ps.isBot === 'boolean') updates.isBot = ps.isBot;
 			if (typeof ps.carefulBot === 'boolean') profileUpdates.carefulBot = ps.carefulBot;
 			if (typeof ps.autoAcceptFollowed === 'boolean') profileUpdates.autoAcceptFollowed = ps.autoAcceptFollowed;

packages/frontend/src/pages/settings/privacy.vue

@@ -29,7 +29,7 @@ SPDX-License-Identifier: AGPL-3.0-only
 		{{ i18n.ts.noCrawle }}
 		<template #caption>{{ i18n.ts.noCrawleDescription }}</template>
 	</MkSwitch>
-	<MkSwitch v-model="isIndexable" @update:modelValue="save()">
+	<MkSwitch v-model="noindex" @update:modelValue="save()">
 		{{ i18n.ts.makeIndexable }}
 		<template #caption>{{ i18n.ts.makeIndexableDescription }}</template>
 	</MkSwitch>
@@ -81,7 +81,7 @@ let isLocked = $ref($i.isLocked);
 let autoAcceptFollowed = $ref($i.autoAcceptFollowed);
 let noCrawle = $ref($i.noCrawle);
 let isExplorable = $ref($i.isExplorable);
-let isIndexable = $ref($i.isIndexable);
+let noindex = $ref($i.noindex);
 let hideOnlineStatus = $ref($i.hideOnlineStatus);
 let publicReactions = $ref($i.publicReactions);
 let ffVisibility = $ref($i.ffVisibility);
@@ -97,7 +97,7 @@ function save() {
 		autoAcceptFollowed: !!autoAcceptFollowed,
 		noCrawle: !!noCrawle,
 		isExplorable: !!isExplorable,
-		isIndexable: !!isIndexable,
+		noindex: !!noindex,
 		hideOnlineStatus: !!hideOnlineStatus,
 		publicReactions: !!publicReactions,
 		ffVisibility: ffVisibility,

packages/misskey-js/src/entities.ts

@@ -37,7 +37,7 @@ export type UserLite = {
 	};
 	isCat?: boolean;
 	isBot?: boolean;
-	isIndexable?: boolean;
+	noindex?: boolean;
 };
 
 export type UserDetailed = UserLite & {
@@ -66,7 +66,7 @@ export type UserDetailed = UserLite & {
 	speakAsCat: boolean;
 	isFollowed: boolean;
 	isFollowing: boolean;
-	isIndexable: boolean;
+	noindex: boolean;
 	isLocked: boolean;
 	isModerator: boolean;
 	isMuted: boolean;