Better error handling

This commit is contained in:
syuilo 2019-06-18 13:58:59 +09:00
parent 285d0d13f9
commit 1a984de8e8
No known key found for this signature in database
GPG key ID: BDC4C49D06AB9D69

View file

@ -8,6 +8,7 @@ import * as bcrypt from 'bcryptjs';
import { Users, UserProfiles } from '../../../../models'; import { Users, UserProfiles } from '../../../../models';
import { ensure } from '../../../../prelude/ensure'; import { ensure } from '../../../../prelude/ensure';
import { sendEmail } from '../../../../services/send-email'; import { sendEmail } from '../../../../services/send-email';
import { ApiError } from '../../error';
export const meta = { export const meta = {
requireCredential: true, requireCredential: true,
@ -27,6 +28,14 @@ export const meta = {
email: { email: {
validator: $.optional.nullable.str validator: $.optional.nullable.str
}, },
},
errors: {
incorrectPassword: {
message: 'Incorrect password.',
code: 'INCORRECT_PASSWORD',
id: 'e54c1d7e-e7d6-4103-86b6-0a95069b4ad3'
},
} }
}; };
@ -37,7 +46,7 @@ export default define(meta, async (ps, user) => {
const same = await bcrypt.compare(ps.password, profile.password!); const same = await bcrypt.compare(ps.password, profile.password!);
if (!same) { if (!same) {
throw new Error('incorrect password'); throw new ApiError(meta.errors.incorrectPassword);
} }
await UserProfiles.update({ userId: user.id }, { await UserProfiles.update({ userId: user.id }, {