From e64cd430b8783afd7f9e15ddf128e4d5188d7487 Mon Sep 17 00:00:00 2001 From: JackDandy Date: Sun, 3 May 2015 01:42:14 +0100 Subject: [PATCH] Fix issue changing a custom show list group name that is in use. The bug resulted in the db containing stale group names but worse, orphaned shows disappeared from the Show List page entirely. PEP8 and code cleanup to SG conventions. Changed texts to describe this feature more clearly from tag to group names. Repositioned this feature on the add show, edit show, and config pages. Change the drop down select to dynamically hide/show the list of group names and change the respectively selected help texts. Change insert space between items in the list of group names for readability. Notify user if an attempt to remove an in use group name is prevented. Change Show List progress bar code, smaller page load, efficient use of js render engine. Removed fixed column widths, this means multiple groups have different column widths, but the original approach is preferred because fixed widths look bad with long show titles. --- CHANGES.md | 12 +- gui/slick/css/style.css | 20 +- .../interfaces/default/config_general.tmpl | 39 +- gui/slick/interfaces/default/editShow.tmpl | 29 +- gui/slick/interfaces/default/home.tmpl | 841 +++++++++--------- .../default/inc_addShowOptions.tmpl | 29 +- gui/slick/interfaces/default/inc_top.tmpl | 461 +++++----- .../interfaces/default/manage_massEdit.tmpl | 4 +- gui/slick/js/config.js | 9 + sickbeard/config.py | 1 + sickbeard/webserve.py | 38 +- 11 files changed, 746 insertions(+), 737 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 73bf8d21..28a3ee34 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -25,12 +25,22 @@ * Fix display of search status for an alternative release after episode is manually set to "Failed" on the Display Show page * Change handle more varieties of media quality * Change to prevent another scheduled search when one of the same type is already running -* Add custom show lists to home page * Change travis to new container builds for faster unit testing * Add handling for shows that do not have a total number of episodes * Add support for country network image files to the Show List view +* Add General Config/Interface/"Group show list shows into:"... to divide shows into groups on the Show List page +* Change Show List progress bar code, smaller page load, efficient use of js render engine * Change values used for date sorting on home page and episode view for improved compatibility with posix systems +[develop changelog] +Fix issue changing a custom show list group name that is in use. The bug resulted in the db containing stale group names +but worse, orphaned shows disappeared from the Show List page entirely. Changed texts to describe this feature more +clearly from tag to group names. Repositioned this feature on the add show, edit show, and config pages. Change the drop +down select to dynamically hide/show the list of group names and change the respectively selected help texts. Change +insert space between items in the list of group names for readability. Notify user if an attempt to remove an in use +group name is prevented. PEP8 and code cleanup to SG conventions. Removed fixed column widths, this means multiple groups +have different column widths, but the original approach is preferred because fixed widths look bad with long show titles. + ### 0.8.3 (2015-04-25 08:48:00 UTC) diff --git a/gui/slick/css/style.css b/gui/slick/css/style.css index 55384396..da88aa60 100644 --- a/gui/slick/css/style.css +++ b/gui/slick/css/style.css @@ -350,6 +350,14 @@ inc_top.tmpl -moz-osx-font-smoothing:grayscale } +.dropdown [class^="sgicon-"], .dropdown [class*=" sgicon-"]{ + margin-right:6px +} + +#SubMenu [class^="sgicon-"], #SubMenu [class*=" sgicon-"]{ + margin-right:3px +} + .sgicon-rss:before{ content:"\e622" } @@ -1591,12 +1599,6 @@ td.col-subtitles{ text-align:center } -th.col-simple, -td.col-simple{ - width: 150px; - text-align: center -} - th.col-status, td.col-status{ width:200px; @@ -2084,7 +2086,7 @@ config*.tmpl .component-group-desc{ float:left; - width:250px; + width:240px; padding-right:10px } @@ -2164,7 +2166,7 @@ config*.tmpl .stepDiv span.component-title, #config span.component-title{ float:left; - width:172px; + width:182px; margin-right:10px; font-size:13px; font-weight:bold @@ -2180,7 +2182,7 @@ config*.tmpl font-weight:normal; display:block; width:475px; - margin-left:182px + margin-left:192px } #config label.space-right{ diff --git a/gui/slick/interfaces/default/config_general.tmpl b/gui/slick/interfaces/default/config_general.tmpl index 5effd04e..9abf8e25 100644 --- a/gui/slick/interfaces/default/config_general.tmpl +++ b/gui/slick/interfaces/default/config_general.tmpl @@ -174,14 +174,14 @@

fetch and install software updates. - Updates are run on startup and in the background at the frequency set below*

+ Updates are run on startup and in the background at the frequency set below1